Automated edits for branches

Thanks!

Sticky?

I’ll be adding Wikidata, Wikipedia, and Wikimedia tags to all branches whenever available.

I don’t think so. Wiki is better than sticky

Whatever suits you

it’s just that editing the template is actually a way to edit the map ,and people should know it exists.

I may have misunderstood what you meant by “Sticky?”.

I thought you’re asking about making this thread sticky in the forum. That, I assume, has nothing to do with templates…

This is what I meant.

The first post of this thread links to the templates which are used by the bot to edit the branches.

I’d like to help with the other templates, starting from supermarkets.

I want to be sure I understand the “syntax” and the script operation correctly. Is this correct?

{ tags: { 
	"name": "מגה", "name:he": "מגה", "name:en": "Mega",
	"name:ar": "", "name:ru": "", "brand":"Mega",
	"shop":"supermarket", "website": "..."
	}, alt_find: [], variants: [

		{ tags: {
			"name" : "מגה בעיר", "name:he":"מגה בעיר", "name:en": "Mega Bair"
			}, alt_find: ["Mega Ba'ir", "Mega Ba'Ir", "Mega BaIr"] 
		},

		{ tags: {
			"name" : "מגה בול", "name:he":"מגה בול", "name:en": "Mega Bool" 
			}, alt_find: [] 
		}
	]
},

Does the script consider case (“Bool” vs “bool”)?
Does the script match the variant before the main brand (“Mega bool” before just “Mega”)?

The syntax is standard JSON and your sample appears fine. I should add a blank template to make this easier.

The script checks all matches. If something matches both a variant and a brand, variant wins. If something matches two unrelated branches or two variants, errors are thrown and my manual intervention is required.

Matching is completely case and whitespace insensitive. bool and Bool are considered the same.

I am considering writing the “matching algorithm” explanation in a more friendly manner.

For your specific example, Mega Bool has a “fuzzy match” for mega but a full match for “mega bool”, so it is matched to mega bool.

The main (Mega) brand template tags are then applied, and then mega bool’s tags are applied on top of them, overriding some of them.

What about the type of the POI? Is it checked/matched as well? Or only the name is matched and all other tags are copied?

For example, if we have amenity=restaurant, name=Hapoalim - will it match to Bank Hapoalim’s template?

if a POI’s amenity=* or shop=* does not already equal the matched brand’s amenity or shop tag, then the POI is left alone and a warning is put in a log for me to manually inspect.

I put considerable thought into these edge cases, but the documentation is probably a bit tricky to read as of now.

Added some supermarkets to the templates.

In anticipation of possible questions:

• I extracted the most common names from an Overpass query for shop=supermarket on the central part of Israel.
• I tried to find “official” names on the supermarkets’ websites, Wikipedia or the most common results on Google.
• Whenever I couldn’t find an official English name, I used the Hebrew Academy’s transcription rules (http://hebrew-academy.org.il/wp-content/uploads/Transcription2_1.pdf) - Ba’Ir, Bul, BaShkhuna, etc…
• Russian names are based on my personal transcription rules, which may not be optimal
• Shufersal Big - according to news articles, this variant is canceled and converted to “Deal”, so added “Big” as alt_find for “Deal”.
• Tiv Ta’am “in the city” - on their website, the branches in Hebrew are named with only a “סיטי” suffix, so that’s what I used.
• Yesh - it appears (from their website, I have no personal knowledge) that the brand is Yesh BaShkhuna. It has a variant - Yesh Hesed. There doesn’t seem to be only “Yesh”.
• Eden Teva Market - on their website, the branding is “Eden Teva” only, without the “market”, so that’s what I used.
• When searching for “Mister Zol”, I came across multiple news articles that it was sold to and became “Coop Shop”, so I added it as alt_find.

Added pharmacies.

Thanks for the effort! I’ll review the changes and run the bot as soon as time permits

What do you think about using the banks templates for ATMs as well?

It sounds reasonable. Do you think this algorithm change is sufficient?:

if (amenity=bank or amenity=atm), attempt regular bank matching rules.

Some of your alt_finds are redundant: e.g. “SuperPharm”, “Super Pharm”. There is a normalization for template values, which ignores upper/lower case spaces, dashes.

I just added all the spelling/formatting variations that I saw being used, I wasn’t aware that spaces and dashes are ignored. Redundant is better than missing, right?

Perhaps it needs to be adjusted to use operator=* instead of name=* for ATMs? It seems to be the recommended and more commonly used way.