Importing official data from Keren Kayemet LeIsrael

As much as I could see (I only did a brief overview) - it looks good! Great job!

I wonder if we could somehow automate all the inner ways.
e.g. this water.

talkat.

I see changes by kkl_import! :slight_smile:
Let us know when we can start tidying up.

Should we decide about tagging non-kkl forests?
Or should future updates just update kkl-managed forests?

talkat.

There are some problems with the import - duplicates. I am looking into it.

Please do not change the objects uploaded by kkl_import. I will try to revert the changes.

Something went wrong with the import script, which caused the duplicate ways.

As far as I understand, there are no duplicate nodes, can you confirm this? If so, recovery should be much easier.

Indeed, it seems to me that there are no duplicate nodes.
There are, however, duplicate ways, sometimes even 3 ways using the same nodes.

talkat.

I suspect that the university firewall somehow interferes with the upload.
I’ll continue from home, later.

dimka

In the meantime, there will be a plenty (around 600,000) of “orphan” nodes around. Please try not to touch them!

Update: I was able to revert the problematic ways and now continue to upload the rest of the stuff.
If all goes well, it will probably take another day or two.

dimka

I already “itch” when I see tagless areas on the map… Let us know :slight_smile:

So far it looks good! :slight_smile:

Here is a nice big chunk that is clearly more accurate than the current data we have.

talkat.

Looks very detailed in compare of our “bing” work :slight_smile:
We will have a very green Israel - Palestine in OSM.

BTW: I have added some notes some days ago to the areas you imported… hope this will not harm the upload. I removed the notes just now.

http://www.openstreetmap.org/?lat=31.79481&lon=35.29368&zoom=15&layers=M

As a matter of fact, I believe that these ways were not reverted automatically precisely because they were changed. If I remember correctly, there should be only around 5 of those. I was planning to “hunt” these after I finish the upload and delete them anyway. Could you please just write their IDs (but do not delete them yourself as I would like all the edits to be done through the kkl_import user).

Just found this: http://www.openstreetmap.org/browse/way/117745023
Seems strange.

Here are some more:
117745024
117744991
117745025
117745008
117744993
117745111

And several others in that area.

talkat.

Another issue:
Way 117745110 has 2 nodes which are practically in the same place.

talkat.

I can’t say for sure, but it is possible that these are all parts of boundaries which are longer than 2000 nodes. In that case there is a split, and the other part(s) just haven’t been uploaded yet.

Right now there is a problem with the upload - the server returns “500 Internal server error”. I have no idea what can be causing this, I just posted a question on the OSM-talk list.

Sounds unlikely, as these are closed ways, polygons.

It could be that KKL’s source has these as errors, or they’re a result of some rounding algorithm when you converted to OSM’s coordinated?

talkat.

If a source polygon has more than 2000 nodes on its boundary, this boundary cannot be represented by a single (closed) way in OSM, in which case there will be a split and the relation will take care of the connection.

I’ve checked the source of http://www.openstreetmap.org/browse/way/117745023: turns out this is a “hole” in elyakim forest: see its counterpart http://api06.dev.openstreetmap.org/browse/way/293395
In the original KKL shapefile there is indeed such a hole, so the problem starts there. I guess it is an error and not some physical feature. After the upload is finished, I’ll ask KKL about those.