OpenStreetMap Forum

The Free Wiki World Map

You are not logged in.

#51 2013-02-26 15:01:10

things-change
Member
Registered: 2011-10-27
Posts: 351

Re: Kendzi3D - 3D Viewer as plugin for JOSM.

kendzi wrote:

I currently read only 5 rows. How many rows should be allowed?


I don't know if more than 5 rows are needed. but with this kind of tagging i could only split the roof in 5 parts, where I can place the dormer.
For example if I have a 5 meter roof and the dormer is 1m away from the edge, I have to place the dormer in row 2. and I have to set a row 5 with no dormer ('3dr:dormers:front:row5=-'). if i don't set row 5, the row 2 is in the middle of the roof.
Because of this I meant, setting the distance from the edge in meters with a tag would be better.

Offline

#52 2013-02-27 19:19:54

kendzi
Member
Registered: 2008-08-20
Posts: 250

Re: Kendzi3D - 3D Viewer as plugin for JOSM.

There are few things to work out with dormers. Currently the easiest way is to add tag 3dr:dormers:front:row5:depth for entire dormers row. We need to work out easy way to add custom tags for each dormer. Some time ago someone proposed to use nodes for dormers.

I for some time try to focus on adding new roof shapes and editor capabilities. So it is good time to write down some ideas about dormers.


New things:

* Holes on flat roofs:
holesforflatroof.th.png

* new half-round roof (5.2)
63383797.th.png

52237758.th.png

The round depends on roof:height tag.

In next release I will change behavior of roof:direction tag. Currently it is pointing form left to right side of building. After change it will pointing to roof front. As it is discussed here.

Offline

#53 2013-03-03 15:18:18

kendzi
Member
Registered: 2008-08-20
Posts: 250

Re: Kendzi3D - 3D Viewer as plugin for JOSM.

In current version v169 I added support for multi-layer texture. Netzwolf prepare multi-layer texture for colored brick. Currently it is possible to change only background color and color of mortar between the bricks can't be changed. But it looks much better then old brick texture.


colorable5.th.png
colorable4.th.png
colorable3.th.png

Currently roof parts of wall aren't using new textures. Comparison between old and new textures:
colorablecom.th.png

Short description how to configure textures.

I hope Netzwolf prepare some more textures wink

Offline

#54 2013-03-03 18:58:42

chris66
Member
From: Germany
Registered: 2009-05-24
Posts: 8,552

Re: Kendzi3D - 3D Viewer as plugin for JOSM.

kendzi wrote:

In next release I will change behavior of roof:direction tag.

There is also a roof:slope:direction (used by osm2world). Is this the same?

Chris


Internettechnik aus Nordkorea: Demnächst auch in der EU?

Offline

#55 2013-03-03 20:07:18

kendzi
Member
Registered: 2008-08-20
Posts: 250

Re: Kendzi3D - 3D Viewer as plugin for JOSM.

Currently it look like this:

roofdirections.th.png

roof:slope:direction tag should be interpreted the same as in Osm2World

Last edited by kendzi (2013-03-03 20:08:17)

Offline

#56 2013-03-04 03:43:51

Tordanik
Moderator
From: Germany
Registered: 2008-06-17
Posts: 2,269
Website

Re: Kendzi3D - 3D Viewer as plugin for JOSM.

kendzi wrote:

In current version v169 I added support for multi-layer texture. Netzwolf prepare multi-layer texture for colored brick. Currently it is possible to change only background color and color of mortar between the bricks can't be changed. But it looks much better then old brick texture.

Does lighting of the mortar between the bricks work correctly for you? If yes, how did you solve that?

roofdirections.th.png

That image is not correct regarding roof:slope:direction. The tag is currently only used for one roof shape in OSM2World, skillion/monopitched, where it is identical to the definition roof:direction for that roof shape: down towards the front.

If we agree to introduce roof:direction, I think roof:slope:direction will become redundant. I would continue to support it for backwards compatibility for a while, but discourage using it further, as it was never properly documented anyway.

Edit: typo

Last edited by Tordanik (2013-03-04 18:08:17)

Offline

#57 2013-03-04 20:53:12

kendzi
Member
Registered: 2008-08-20
Posts: 250

Re: Kendzi3D - 3D Viewer as plugin for JOSM.

Tordanik wrote:

Does lighting of the mortar between the bricks work correctly for you? If yes, how did you solve that?

I didn't. I think that can be done using two over layers for mortar. First combine (interpolate) alpha and color and on second combine lighting and alpha. But glTexEnvi is deprecated and in modern OpenGl this is solved by shaderes. So I don't plan currently adding two over layers for mortar and windows.

But even without proper lighting new multilayer textures look better then old ones.

Nice description of glTexEnvi is here.

Tordanik wrote:

That image is not correct regarding roof:slope:direction.

I didn't understand your description here of this tag. I fixed image and I will fix it in my application soon.
roofdirections.th.png

Offline

#58 2013-03-06 19:52:24

kendzi
Member
Registered: 2008-08-20
Posts: 250

Re: Kendzi3D - 3D Viewer as plugin for JOSM.

Tordanik wrote:

Does lighting of the mortar between the bricks work correctly for you? If yes, how did you solve that?

After few trials it can be done using glTexEnvi But you can't use ambient or diffuse color for coloring textures.

I archive this using one additional texture unit:

* Unit 1
Interpolate texture color with texture

* Unit2
Interpolate over-layer with previous result using alpha

* Unit3
Multiple by lighting (environment)

Result:
colorablelighting1.th.png
colorablelighting2.th.png

Advance of this is that it use transparency exactly like in Netzwolf css example.

Last edited by kendzi (2013-03-06 19:52:54)

Offline

#59 2013-08-03 22:20:19

kendzi
Member
Registered: 2008-08-20
Posts: 250

Re: Kendzi3D - 3D Viewer as plugin for JOSM.

* In last version of plug-in was added support for basic roof lines:
ecy2.th.png

It is very basic support for roof line tagging schema. I'm using algorithm invented by Tordanik. Which is really nice. Triangulation code come from hjanetzek. So results should be similar to O2W. It would be nice to known if you find some non working examples.

* Basic editor for building height. It still need lot of work but it should be possible to use it.

bzrz.th.png

Offline

#60 2013-09-01 12:07:41

things-change
Member
Registered: 2011-10-27
Posts: 351

Re: Kendzi3D - 3D Viewer as plugin for JOSM.

Hy, i think it would be a good idea to set an default height for building=garage that is smaller than the default height for buildings. 2,5m for example.

Offline

#61 2013-09-14 20:24:46

marek kleciak
Member
Registered: 2010-10-11
Posts: 8,413

Re: Kendzi3D - 3D Viewer as plugin for JOSM.

Yes. May I suggest 2,70? this Height includes roof construction.
Best regards,
Marek

Offline

#62 2013-09-15 13:00:15

Zkir
Member
From: Хрустальная Москва
Registered: 2009-02-21
Posts: 6,086

Re: Kendzi3D - 3D Viewer as plugin for JOSM.

Hi guys, I hope it's correct place to discuss this issue.

Kendzi 3d plugin is nice, but there is also a big problem.

Kendzi 3d extrudes the third dimention from the building outline (polygon or multipolygon with building=yes+building:levels) even if there are building parts (polygons or multipolygons  puilding:part=yes), inside this building.

In the Simple_3D_Buildings  http://wiki.openstreetmap.org/wiki/Simple_3D_Buildings it is stated that it should NOT be done:

Note that if a building=* contains at least one area tagged as building:part=*, the building outline is no longer considered for volume rendering

As the result, some buildings are rendered correctly in F4 and completely wrong in Kendzi 3d:
Examples:
http://www.openstreetmap.org/browse/relation/2888456
How it is now:
k3d_1.png

How it should be:
k3d_2.png

(I’ve just removed Building=yes from the outline)

How it looks in F4
http://map.f4-group.com/#lat=56.3297870 … .715&la=la

Is this a known problem? Is it possible to fix it?

It's important, because the common practice is to map the building outline with polygon with building=yes for 2d renderes, and add to the building=yes tags for the total height of the building and its total levels,  even if the building has complex shape.


Истинные слова не не приятны, приятные слова не истинны.
True words are unpleasant; pleasant words are untrue.

Offline

#63 2013-09-15 13:07:47

kendzi
Member
Registered: 2008-08-20
Posts: 250

Re: Kendzi3D - 3D Viewer as plugin for JOSM.

Zkir wrote:

Is this a known problem? Is it possible to fix it?

F4 map try to automatically connect building parts with outline and remove outline if it is not necessary. In kendzi3d you need to add all parts and outline to relation type=building then you should get the same result.

Example:
http://www.openstreetmap.org/browse/relation/3208173

Last edited by kendzi (2013-09-15 13:17:09)

Offline

#64 2013-09-15 16:27:59

Zkir
Member
From: Хрустальная Москва
Registered: 2009-02-21
Posts: 6,086

Re: Kendzi3D - 3D Viewer as plugin for JOSM.

Thanks,

However, may be it's possible to consider implementing the same algorith in Kendzi 3d, as in F4?  Currently Kendzi 3d plugin is rather a tool for preparing models for F4 (and possibly other renders) in Josm. It looks very confusing, when you download some building which looks correctly in F4 (renderer), and it is corrupted in Josm/Kendzi 3d (editor).


Истинные слова не не приятны, приятные слова не истинны.
True words are unpleasant; pleasant words are untrue.

Offline

#65 2013-09-15 16:49:26

kendzi
Member
Registered: 2008-08-20
Posts: 250

Re: Kendzi3D - 3D Viewer as plugin for JOSM.

I don't see why not, but there are some major problems with it:
1. F4 for searching polygons inside polygons uses DB function, JOSM don't have any fast and indexed function for that, so it have to be implemented.
2. Searching entire data set for polygons inside polygons will be slow.
3. Personally I think it is an error if building relation don't exist. I see checking for that more as validation rule.

I will think about it in future but don't expect it fast...

Last edited by kendzi (2013-09-15 16:57:50)

Offline

#66 2013-09-16 08:52:48

cmif4
Member
From: Paris
Registered: 2013-06-10
Posts: 121
Website

Re: Kendzi3D - 3D Viewer as plugin for JOSM.

I agree with Kendzi, don't expect F4map and Kendzi3D to match on everything.

They are distinct software maintained by distinct people. We could converge to similar rendering on most case (i already got in touch with Kendzi to uniformize some tag handling) but it will never be perfectly matching as we are using different algorithm and technologies.

By the way i'm glad you enjoy both Kendzi3D and F4map.

Offline

#67 2013-09-16 09:30:19

Zkir
Member
From: Хрустальная Москва
Registered: 2009-02-21
Posts: 6,086

Re: Kendzi3D - 3D Viewer as plugin for JOSM.

Yea, I enjoy Kendzi3D and F4map, thanks to you both for your efforts.
smile

Different web-browsers may use different algorithms, but  they should produce more or less the same result.  For example this very page looks the same way in Crome and IE smile

I hope that different OSM-3D applications will achieve the same level of convergence, and will follow the same basic conventions. Otherwise OSM-3D will not be usable. Why to use Kendzi3d? Just adjust tags, upload data to osm, and wait to see how it will be rendered in F4.

Regarding building relation – I do not think that is should be a must. The majority of building parts do not have it. What to do with them? Do not render them?

P.S.
At least the basic idea {the building outline should not be extruded if there are building parts} is accepted and not argued. It's good smile

P.P.S.
There are quick and easy to use implementations of the R-Tree for java, e.g. http://sourceforge.net/projects/jsi/  I use it to find junctions smile

Last edited by Zkir (2013-09-16 09:49:56)


Истинные слова не не приятны, приятные слова не истинны.
True words are unpleasant; pleasant words are untrue.

Offline

#68 2013-09-16 09:47:56

chris66
Member
From: Germany
Registered: 2009-05-24
Posts: 8,552

Re: Kendzi3D - 3D Viewer as plugin for JOSM.

OSM2World also does not need the relation, but does some funny logic.

It subtracts all building-parts from the building. So, if the building-outline should not be rendered, it must be covered
fully with the building-parts.

I don't find Kenzi's approach to bad. Advantage is you have full control: Building should not be rendered ->
use relation, otherwise don't put it to the relation.

Last edited by chris66 (2013-09-16 09:50:03)


Internettechnik aus Nordkorea: Demnächst auch in der EU?

Offline

#69 2013-09-16 10:07:36

cmif4
Member
From: Paris
Registered: 2013-06-10
Posts: 121
Website

Re: Kendzi3D - 3D Viewer as plugin for JOSM.

chris66 wrote:

OSM2World also does not need the relation, but does some funny logic.

It subtracts all building-parts from the building. So, if the building-outline should not be rendered, it must be covered
fully with the building-parts.

F4maps does the same using the same database request wink

Offline

#70 2013-09-17 00:52:09

things-change
Member
Registered: 2011-10-27
Posts: 351

Re: Kendzi3D - 3D Viewer as plugin for JOSM.

Doesn't kendzi (or f4 map) support building parts as lines? I've got a building with a glass front (not over the complete height). So I drawed a line on this building site, and set building:part and materiel=glass but this didn't work. On kendzi plugin the building was completely gone.

Offline

#71 2013-09-17 01:54:34

rayquaza
Member
From: DE-BW
Registered: 2012-11-18
Posts: 2,007

Re: Kendzi3D - 3D Viewer as plugin for JOSM.

things-change wrote:

Doesn't kendzi (or f4 map) support building parts as lines? I've got a building with a glass front (not over the complete height). So I drawed a line on this building site, and set building:part and materiel=glass but this didn't work. On kendzi plugin the building was completely gone.

Afaik that's exactly what I would expect: "building:part"=* as a non-closed way is not defined and if there's a "building:part"=* within (since it's not defined I'd say it is not wrong to interpret it as "within", but in this case that's what you want anyway) the Buildings outline the latter should be ignored (aka "be completely gone").

Offline

#72 2013-09-17 08:48:33

kendzi
Member
Registered: 2008-08-20
Posts: 250

Re: Kendzi3D - 3D Viewer as plugin for JOSM.

You should think about current SB3D buildings as of solids. You can change in kendzi3d material of one of walls by tagging building as multipolygon and as member you need to add all it's walls. One of them you can tag with different building:material tag.

Offline

#73 2013-09-17 19:08:54

things-change
Member
Registered: 2011-10-27
Posts: 351

Re: Kendzi3D - 3D Viewer as plugin for JOSM.

Ok, i've done now. but i doesn't work.

I've got a line with building:material=glass. Another line for the rest of the building with building:facade:colour=#XXXXXX. Both are part of a relation. type=multipolygon. the lines have role=outer.
where do i tag the height and min_height? at the keys for the multi polygon? i did, but i don't see the wall i've tagged.

Offline

#74 2013-09-17 19:40:59

kendzi
Member
Registered: 2008-08-20
Posts: 250

Re: Kendzi3D - 3D Viewer as plugin for JOSM.

Here is an example:
http://www.openstreetmap.org.pl/kendzi/ … 20wall.osm
Tags height and min_height should be put on multipolygon it self

Result:
pqha.th.png

Offline

#75 2013-09-18 14:48:21

Zkir
Member
From: Хрустальная Москва
Registered: 2009-02-21
Posts: 6,086

Re: Kendzi3D - 3D Viewer as plugin for JOSM.

Hi, one more enhancement request for  Kendzi)
Is it possible to support color names, from this list:
https://github.com/One-com/one-color/bl … dColors.js

For example, firebrick is quite popular colour already.


Истинные слова не не приятны, приятные слова не истинны.
True words are unpleasant; pleasant words are untrue.

Offline

Board footer

Powered by FluxBB