You are not logged in.

#26 2011-06-07 07:52:39

dimka
Member
Registered: 2010-04-01
Posts: 257

Re: Importing official data from Keren Kayemet LeIsrael

talkat wrote:
dimka wrote:
talkat wrote:

Because landuse=forest can be used in either nodes or areas (closed ways)
Not in ways (lines)

talkat.

So maybe this is another reason not to tag individual ways?

Sure, but how would the forest relation know how to connect them?

You'd need a relation to contain each of these more-than-2000-nodes-areas and add this relation to the forest's relation (and not the individual ways that are part of the "smaller" relation)

talkat.

I believe this is no problem - look here at Figure 6.

Offline

#27 2011-06-07 10:52:38

talkat
Member
Registered: 2009-03-06
Posts: 381

Re: Importing official data from Keren Kayemet LeIsrael

dimka wrote:
talkat wrote:
dimka wrote:

So maybe this is another reason not to tag individual ways?

Sure, but how would the forest relation know how to connect them?

You'd need a relation to contain each of these more-than-2000-nodes-areas and add this relation to the forest's relation (and not the individual ways that are part of the "smaller" relation)

talkat.

I believe this is no problem - look here at Figure 6.

Ok, go for it.
Hopefully this is supported in all the popular renderers (mapnik, osmarender, mkgmap, osm2gpsmid, etc.)

talkat.

Offline

#28 2011-06-07 11:11:11

dimka
Member
Registered: 2010-04-01
Posts: 257

Re: Importing official data from Keren Kayemet LeIsrael

talkat wrote:

Hopefully this is supported in all the popular renderers (mapnik, osmarender, mkgmap, osm2gpsmid, etc.)
talkat.

I understand your concern. To be sure, I will take one such relation in OSM format and try to produce a mapnik/osmarender image as well as a Garmin map (unfortunately I don't have experience with osm2gpsmid).

Offline

#29 2011-06-07 11:59:48

talkat
Member
Registered: 2009-03-06
Posts: 381

Re: Importing official data from Keren Kayemet LeIsrael

dimka wrote:
talkat wrote:

Hopefully this is supported in all the popular renderers (mapnik, osmarender, mkgmap, osm2gpsmid, etc.)
talkat.

I understand your concern. To be sure, I will take one such relation in OSM format and try to produce a mapnik/osmarender image as well as a Garmin map (unfortunately I don't have experience with osm2gpsmid).

I can test osm2gpsmid.
But if all other renderers work (and osm2gpsmid doesn't) - then it's good enough for me (if my vote counts, that is...)

talkat.

Offline

#30 2011-06-07 20:48:57

dimka
Member
Registered: 2010-04-01
Posts: 257

Re: Importing official data from Keren Kayemet LeIsrael

I've checked mapnik, osmarender (new version, orp.pl) and mkgmap - all of them render the multipolygons with untagged+splitted ways just fine.

I will be therefore proceeding with the import on the live database soon.

Offline

#31 2011-06-07 21:25:48

talkat
Member
Registered: 2009-03-06
Posts: 381

Re: Importing official data from Keren Kayemet LeIsrael

dimka wrote:

I've checked mapnik, osmarender (new version, orp.pl) and mkgmap - all of them render the multipolygons with untagged+splitted ways just fine.

I will be therefore proceeding with the import on the live database soon.

Cheers!
Hope the import will be smooth.

I'll create a list in the wiki with all forests, like the places and municipalities.

Maybe we could have a list of non-KKL forests as well?
So we could see whether we'd like to keep them or not, and if we want to keep them - to tag them accordingly.

talkat.

Offline

#32 2011-06-11 13:47:26

dimka
Member
Registered: 2010-04-01
Posts: 257

Re: Importing official data from Keren Kayemet LeIsrael

One last test before the actual upload was successful.
You can review all the data via
http://api06.dev.openstreetmap.org/brow … eset/11130

Do you want to run some tests (scripts etc.) on the test database before the actual upload?

dimka

Offline

#33 2011-06-11 17:01:47

talkat
Member
Registered: 2009-03-06
Posts: 381

Re: Importing official data from Keren Kayemet LeIsrael

dimka wrote:

One last test before the actual upload was successful.
You can review all the data via
http://api06.dev.openstreetmap.org/brow … eset/11130

As much as I could see (I only did a brief overview) - it looks good! Great job!

I wonder if we could somehow automate all the inner ways.
e.g. this water.

talkat.

Offline

#34 2011-06-13 07:19:46

adrukh
Member
Registered: 2010-03-19
Posts: 86

Re: Importing official data from Keren Kayemet LeIsrael

I see changes by kkl_import! smile
Let us know when we can start tidying up.

Offline

#35 2011-06-13 07:47:50

talkat
Member
Registered: 2009-03-06
Posts: 381

Re: Importing official data from Keren Kayemet LeIsrael

adrukh wrote:

I see changes by kkl_import! smile
Let us know when we can start tidying up.

Should we decide about tagging non-kkl forests?
Or should future updates just update kkl-managed forests?

talkat.

Offline

#36 2011-06-13 08:36:17

dimka
Member
Registered: 2010-04-01
Posts: 257

Re: Importing official data from Keren Kayemet LeIsrael

There are some problems with the import - duplicates. I am looking into it.

Last edited by dimka (2011-06-13 08:36:26)

Offline

#37 2011-06-13 08:53:38

dimka
Member
Registered: 2010-04-01
Posts: 257

Re: Importing official data from Keren Kayemet LeIsrael

Please do not change the objects uploaded by kkl_import. I will try to revert the changes.

Offline

#38 2011-06-13 10:19:40

dimka
Member
Registered: 2010-04-01
Posts: 257

Re: Importing official data from Keren Kayemet LeIsrael

Something went wrong with the import script, which caused the duplicate ways.

As far as I understand, there are no duplicate nodes, can you confirm this? If so, recovery should be much easier.

Offline

#39 2011-06-13 10:57:33

talkat
Member
Registered: 2009-03-06
Posts: 381

Re: Importing official data from Keren Kayemet LeIsrael

dimka wrote:

Something went wrong with the import script, which caused the duplicate ways.

As far as I understand, there are no duplicate nodes, can you confirm this? If so, recovery should be much easier.

Indeed, it seems to me that there are no duplicate nodes.
There are, however, duplicate ways, sometimes even 3 ways using the same nodes.

talkat.

Offline

#40 2011-06-13 12:14:11

dimka
Member
Registered: 2010-04-01
Posts: 257

Re: Importing official data from Keren Kayemet LeIsrael

I suspect that the university firewall somehow interferes with the upload.
I'll continue from home, later.

dimka

Offline

#41 2011-06-13 21:28:48

dimka
Member
Registered: 2010-04-01
Posts: 257

Re: Importing official data from Keren Kayemet LeIsrael

In the meantime, there will be a plenty (around 600,000)  of "orphan" nodes  around. Please try not to  touch them!

Offline

#42 2011-06-15 21:24:24

dimka
Member
Registered: 2010-04-01
Posts: 257

Re: Importing official data from Keren Kayemet LeIsrael

Update: I was able to revert the problematic ways and now continue to upload the rest of the stuff.
If all goes well, it will probably take another day or two.

dimka

Offline

#43 2011-06-15 22:52:37

adrukh
Member
Registered: 2010-03-19
Posts: 86

Re: Importing official data from Keren Kayemet LeIsrael

dimka wrote:

Update: I was able to revert the problematic ways and now continue to upload the rest of the stuff.
If all goes well, it will probably take another day or two.

dimka

I already "itch" when I see tagless areas on the map... Let us know smile

Offline

#44 2011-06-16 05:13:54

talkat
Member
Registered: 2009-03-06
Posts: 381

Re: Importing official data from Keren Kayemet LeIsrael

dimka wrote:

Update: I was able to revert the problematic ways and now continue to upload the rest of the stuff.
If all goes well, it will probably take another day or two.

So far it looks good! :-)

Here is a nice big chunk that is clearly more accurate than the current data we have.

talkat.

Offline

#45 2011-06-16 14:27:31

Mr_Israel
Moderator
From: Israel, Germany
Registered: 2009-03-02
Posts: 513

Re: Importing official data from Keren Kayemet LeIsrael

Looks very detailed in compare of our "bing" work smile
We will have a very green Israel - Palestine in OSM.

BTW: I have added some notes some days ago to the areas you imported... hope this will not harm the upload. I removed the notes just now.

http://www.openstreetmap.org/?lat=31.79 … 5&layers=M

Last edited by Mr_Israel (2011-06-16 14:28:06)

Offline

#46 2011-06-16 14:38:27

dimka
Member
Registered: 2010-04-01
Posts: 257

Re: Importing official data from Keren Kayemet LeIsrael

Mr_Israel wrote:

BTW: I have added some notes some days ago to the areas you imported... hope this will not harm the upload. I removed the notes just now.

http://www.openstreetmap.org/?lat=31.79 … 5&layers=M

As a matter of fact, I believe that these ways were not reverted automatically precisely because they were changed. If I remember correctly, there should be only around 5 of those. I was planning to "hunt" these after I finish the upload and delete them anyway. Could you please just write their IDs (but do not delete them yourself as I would like all the edits to be done through the kkl_import user).

Offline

#47 2011-06-16 16:01:22

adrukh
Member
Registered: 2010-03-19
Posts: 86

Re: Importing official data from Keren Kayemet LeIsrael

Just found this: http://www.openstreetmap.org/browse/way/117745023
Seems strange.

Offline

#48 2011-06-16 16:45:51

talkat
Member
Registered: 2009-03-06
Posts: 381

Re: Importing official data from Keren Kayemet LeIsrael

adrukh wrote:

Here are some more:
117745024
117744991
117745025
117745008
117744993
117745111

And several others in that area.

talkat.

Offline

#49 2011-06-16 16:49:44

talkat
Member
Registered: 2009-03-06
Posts: 381

Re: Importing official data from Keren Kayemet LeIsrael

Another issue:
Way 117745110 has 2 nodes which are practically in the same place.

talkat.

Offline

#50 2011-06-16 19:40:00

dimka
Member
Registered: 2010-04-01
Posts: 257

Re: Importing official data from Keren Kayemet LeIsrael

talkat wrote:
adrukh wrote:

Here are some more:
117745024
117744991
117745025
117745008
117744993
117745111

And several others in that area.

talkat.

I can't say for sure, but it is possible that these are all parts of boundaries which are longer than 2000 nodes. In that case there is a split, and the other part(s) just haven't been uploaded yet.

Right now there is a problem with the upload - the server returns "500 Internal server error". I have no idea what can be causing this, I just posted a question on the OSM-talk list.

Offline

Board footer

Powered by FluxBB