mapnik RTL linebreaks bug

Hi all,

I would like to try and submit a patch for mapnik to fix this annoying bug (one of several: http://trac.mapnik.org/wiki/InternationalText)

I’ve managed to set up a mapnik development environment and already am having some progress.

What I would like to have is a list of test cases. The basic one is just all-Hebrew name which spans several lines, but there may also be mixed English-Hebrew, Hebrew with numbers etc.

I will most grateful if you guys posted here links to OSM bounding boxes (again, covering as many different situations as possible) so that I can test these on my local computer.

If anybody here has some C++/Unicode (they use ICU library http://icu-project.org ) skills and wants to help - please indicate so.

dimka

GREAT THAT YOU CHECKING THIS OUT!

I actually could find this issue only with Hebrew.

This one is really looking strange and I just couldn’t find this issue in the Arab world but I remember they had the same issues:

Here are several examples of the wrong wording direction in Israel:

How about this? :slight_smile:

http://flic.kr/s/aHsjvKJEwd

The problem of mirroring (reverse “)” and “(” ) is beyond me right now, the above fix is a quick-and-dirty one which I hope will be incorporated until a more permanent solution is found.

I will be submitting the patch to mapnik.

dimka

Patch submitted.

I’ve updated both
http://trac.openstreetmap.org/ticket/1515
and
http://trac.mapnik.org/ticket/189

dimka

Finally Finally Finally … :slight_smile:

Great job Dimka !

Dimka, you’re my hero

I imagine this can quickly be incorporated into mapnik, especially with the attention of Dane

As for getting it deployed on the OSM tile renderer, if any blocks are thrown up, just let me know and I’ll do what I can to get this live

FYI: my patch has been applied to mapnik trunk, and it will be included in the upcoming Mapnik 2.0 release.

Also, another Right-to-Left bug has been solved - namely, mirroring (see http://trac.mapnik.org/ticket/364)). Thanks to user itayperl!

I hope we will see the rendering on the main OSM site fixed soon.

dimka, that’s great news. I’ve asked the OSM sysadmin team about their plans with mapnik 2, and will get back to you when I know more.

Do we already know when the bug will be fixed in the main rendering engine?

The fix has been released as part of Mapnik 2.0 for some time now.
Question is, when osm.org will be updated to that version?

See
http://trac.openstreetmap.org/ticket/1515

dimka

I’m told that mapnik on the tile server has been updated to mapnik 2. Do you see improvements in the rendering for RTL?

I can’t find any changes.

Example:
http://www.openstreetmap.org/?lat=32.70425&lon=35.05525&zoom=12&layers=M&mlat=32.69141&mlon=35.04730

The place name is Daliat El Camriel. But the Order of Hebrew says El Carmiel Daliat